RDN-1270
1

Annual Events Issue

Scott on 10/21/2015 8:55 PM

Scott on 2/15/2016 5:35 PM

%
(hrs)
Logged

0 (hrs)


 Description

In RDN.League > League > Calendar > Create Event

  1. Create a new calendar event.
  2. Set this event to Reocurr once a year for the next three years.
  3. This should be the problem.  The event gets created, but doesn't start on the date it was created nor does it get created on the right dates in the future.

 

 

If you are able to view our league's calendar, I entered two events today; one for April 15th annually and one for October 7th annually. Both only show up on October 20, 2016.

As I'm entering events today with annual repeats, it is posting them as of exactly a year from now and that's it.

 

AAAAHHHHH!

 

Every time I go in to correct it, it doesn't change.

 

Thanks,

Skip Navigation Links
 

Scott Wednesday, January 20, 2016 8:40 PM #

Good job.  Seems like it was a stupid simple fix.

 

Icatalin Monday, January 11, 2016 6:11 PM #

I have done some fixing, I also created a pull request. For daily, weekly, monthly and yearly now it works without any problem. But unfortunately I haven't been able to make it work for quarterly. I have tried multiple times with good date ranges and multiple combinations similar to weekly and monthly but  no success. ;(

 

Scott Saturday, January 09, 2016 12:42 AM #

I like your JS solution.  While I was familiar with the code at one time, Im not too familiar anymore with it.  So I trust your thoughts and solution.  Go ahead and give it a try.

If you did the JS solution, you will need to add it to the following places.

  1. Create Event
  2. Edit Event - Maybe not here.
  3. Edit Reocurring Event

Go ahead and see what you can do.

 

Icatalin Friday, January 08, 2016 4:03 PM #

For weekly it only works if the user selects at least one day, and it is normal behaviour to do so, but the user has the possibility to add a weekly event without selecting a day which will return an error. How would you want to handle this?

Similar problem is for Monthly if the users selects a day ( first monday of the month ...) it is ok, but if it doesn't selects any day is should insert in the first day of the month ( event if the MonthlyInterval is correctly set to 1 - MonthlyIntervalEnum.First) it doesn't work. 
But now I think that this MonthlyIntervalEnum with (First, Last, Second ...) is not the day of the month (1 -Feb ,2- Feb ,3-Feb,) but it is the nr-th of that month ( 1 [first]- monday of Feb, 2[second]- moday of Feb ... etc.)
The idea is that like weekly this also needs at least one day ( monday, tu, we , ....) selected to work. If the DaysOfWeek are 0 this lib doesn't consider first day of the month (day 1) as date for the event.

I was thinking for a solution ( in js),  if the user selects weekly or monthly and no days are checked that button - Done -from Life Event to be disabled. 

Let me know what do you think I should do.

 

Scott Monday, January 04, 2016 8:22 PM #

Ya, I know the issue well.

Thats why you have the issue.  I think your good at rational thought.  At least from what I have seen.  

Feel free to make other updates if there are more issues than just this one.

 

Icatalin Sunday, January 03, 2016 6:56 PM #

This one was crazy ;) to debug and find the issue. ( very poor documentation and examples is this http://www.squarewidget.com/schedulewidget-and-fullcalendar)

Also there is a similar issue with the Weekly, Monthly and Quarterly , for weekly an error will be cause by this

int daysToAdd = (endsOnOcurrences / howManyDays) * 7; 

because howManyDays is 0.

Let me know if I should do something about this.

 

Scott Thursday, December 31, 2015 5:22 PM #

that is correct.  Can you get it working?

 

Icatalin Wednesday, December 30, 2015 8:26 PM #

If I have understood the code correctly the events are added in a foreach
foreach (var date in schedule.Occurrences(range)) in public static Guid CreateNewEventReOcurring(Guid calId ....  ) from CalendarEventFactory.cs
for daily it works but for months and years this schedule.Occurrences(range) returns an empty collection and no events are added.

My question is, did I understand this correctly? And should I do something so that schedule.Occurrences(range) will not be empty any more? And also how this schedule.Occurrences works?

Thanks!


Powered by BugNET 1.6.339.0